Skip to content

Conversation

@profxj
Copy link
Contributor

@profxj profxj commented Nov 12, 2025

Something somtehing

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new RatioPrior class to support CDOM/aph ratio priors and adds 2D histogram plotting capabilities. The changes enable more flexible prior configuration for Bayesian inference in bio-optical modeling.

Key Changes:

  • Added RatioPrior class for handling ratio-based priors (e.g., CDOM/aph ratios) with Gaussian constraints
  • Introduced hist2d function for 2D histogram plotting with contours and density maps
  • Enhanced prior system with add_prior method and support for extra priors beyond individual parameters

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 16 comments.

File Description
bing/priors/priors.py Implements RatioPrior class, refactors prior management with add_prior method, and updates calc method to handle both individual and ratio priors
bing/plotting.py Adds hist2d function for 2D histogram visualization with contour and density plotting capabilities, including helper functions for axis limit management
bing/parameters/p_ntuple.py Updates parameter documentation to clarify that apriors/bpriors are lists of dicts and adds othera_priors parameter
bing/fitting/l23.py Adds support for ag (absorption by dissolved material) tracking, integrates othera_priors, and adds optional p0 parameter to fit_one function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

profxj and others added 6 commits November 13, 2025 10:56
copilot!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
i0, i1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
deprecated

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rm

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Nov 13, 2025

@profxj I've opened a new pull request, #13, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Nov 13, 2025

@profxj I've opened a new pull request, #14, to work on those changes. Once the pull request is ready, I'll request review from you.

profxj and others added 5 commits November 13, 2025 11:00
whoa

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
[WIP] Address feedback from review on CDOM aph pull request
[WIP] WIP to address feedback on CDOM aph pull request
@profxj profxj merged commit fbe44e0 into main Nov 13, 2025
@profxj profxj deleted the cdom_aph branch November 13, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants