-
Notifications
You must be signed in to change notification settings - Fork 0
CDOM aph #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new RatioPrior class to support CDOM/aph ratio priors and adds 2D histogram plotting capabilities. The changes enable more flexible prior configuration for Bayesian inference in bio-optical modeling.
Key Changes:
- Added
RatioPriorclass for handling ratio-based priors (e.g., CDOM/aph ratios) with Gaussian constraints - Introduced
hist2dfunction for 2D histogram plotting with contours and density maps - Enhanced prior system with
add_priormethod and support for extra priors beyond individual parameters
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 16 comments.
| File | Description |
|---|---|
| bing/priors/priors.py | Implements RatioPrior class, refactors prior management with add_prior method, and updates calc method to handle both individual and ratio priors |
| bing/plotting.py | Adds hist2d function for 2D histogram visualization with contour and density plotting capabilities, including helper functions for axis limit management |
| bing/parameters/p_ntuple.py | Updates parameter documentation to clarify that apriors/bpriors are lists of dicts and adds othera_priors parameter |
| bing/fitting/l23.py | Adds support for ag (absorption by dissolved material) tracking, integrates othera_priors, and adds optional p0 parameter to fit_one function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
copilot! Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
i0, i1 Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
deprecated Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rm Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
whoa Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
[WIP] Address feedback from review on CDOM aph pull request
[WIP] WIP to address feedback on CDOM aph pull request
Something somtehing