Only use ocaml-env if it is available #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh. The code looks good, but I haven't been able to build the code on my Windows machine. Last time I tried successfully was a year ago; the CI for Windows is also broken. Anyways, LGTM. Thanks! |
|
I don't have Diskuv OCaml installed on my Windows computer, but when I removed I've attached a .vsix package of the extension (inside a .zip) with these changes if you'd like to try them in your environment: test_extension.zip You can install it through these steps: https://code.visualstudio.com/docs/editor/extension-marketplace#_install-from-a-vsix |
rgrinberg
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #977
This PR allows the extension to automatically use the Diskuv OCaml Windows executables from the PATH when
ocaml-envdoes not exist.