Skip to content

Added discussion links #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dldisha
Copy link

@dldisha dldisha commented Apr 16, 2021

Issue Description

To display an external link to the discussion forum and add a link to the corresponding discussion at the bottom of each tutorial on the website.

Fixes #1504

Changes Made

After:

External link:
Screenshot from 2021-04-17 03-20-52

Discuss link at the bottom of each tutorial:
Screenshot from 2021-04-17 03-52-01

If this seems fine, I'll add the same link at the bottom of other tutorials also. :)

  • Please check if the PR fulfills these requirements
  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

@patricoferris
Copy link
Contributor

Hi @dldisha thanks for this PR.

In your description of it you say

add a link to the corresponding discussion at the bottom of each tutorial on the website

Unless I'm mistaken, it looks like you've only added it the main learn page and the up_and_running tutorial? Is this intentional?

@dldisha
Copy link
Author

dldisha commented Apr 19, 2021

Yes @patricoferris, because I first wanted a mentor to check my code changes as this is just a test(I guess). And if that all seems fine I'll do the same for each tutorial. Didn't want to pile up the wrong commits.
So should I move forward with other tutorials?

@gs0510
Copy link

gs0510 commented Apr 21, 2021

@dldisha You can go ahead and add it to all tutorials :) Thanks!

@dldisha
Copy link
Author

dldisha commented Apr 21, 2021

@gs0510 Done! please check.

@gs0510
Copy link

gs0510 commented Apr 22, 2021

@dldisha Thanks! Can you rebase your PR against master to remove the conflicts? Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a thread in discuss for each tutorial, add links on site
3 participants