Skip to content

Changed font size in the website to improve user experience #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SAY-droid427
Copy link

@SAY-droid427 SAY-droid427 commented Apr 3, 2021

Issue Description

Please include a summary of the issue.

Fixes ocaml/ocaml.org#1388

Changes Made

Increased the font size in the website. The original font size was too small and difficult to read.
BEFORE:

OcamlBefore1
OcamlBefore2

AFTER:

OcamlAfter1
OCamlAfter2

  • Please check if the PR fulfills these requirements
  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

@patricoferris
Copy link
Contributor

Hi @SAY-droid427, thanks for the PR :))

This looks like a good fix but it would be great if you could add some before and after images. This helps reviewing the PR before we push it to say staging, thanks.

@SAY-droid427
Copy link
Author

@patricoferris I have added the before and after images. The font-size was very small initially and not legible. I have increased the font-size to make it legible and clear. Please review.

@avsm avsm added the pushed-to-staging pushed to staging.ocaml.org label Apr 6, 2021
@avsm
Copy link
Member

avsm commented Apr 6, 2021

@SAY-droid427 I approve of the general principle of increasing the font size of long-form text, but the change in it's current form isn't suitable to be merged as it leads to a number of layout issues with the larger font size.

For example there is overflow here:
image

And inconsistent sizes now here on the front page:
image

Please do feel free to continue iterating on this, but a global change is going to be tricky. It may be better to pick specific templates and tweak those font sizes, rather than apply it across elements.

@avsm avsm removed the pushed-to-staging pushed to staging.ocaml.org label Apr 6, 2021
@avsm avsm marked this pull request as draft April 13, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the font-size of the website to improve the user experience
3 participants