Trim the output of git-config
#652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cknitt - I've tested with this PR on my fork of rescript-compiler which appears to be working. Once this is merged and released, you should be able to revert rescript-lang/rescript#6034. |
smorimoto
approved these changes
Mar 9, 2023
|
Thanks a lot for your work @dra27! |
Signed-off-by: Sora Morimoto <sora@morimoto.io>
|
Shipped in v2.0.12 (Of course in v2)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#647 reads the output of
git config --global core.autocrlfin order to restore it afterwards. It wasn't trimming the newline from stdout, so if the workflow had changed the setting then it was restored with a\ncharacter at the end which results in a corrupt git configuration.