Skip to content

[new release] ppxlib (3 packages) (0.36.1) #28160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NathanReb
Copy link
Contributor

Standard infrastructure for ppx rewriters

CHANGES:

@NathanReb
Copy link
Contributor Author

CC @hhugo you should be able to use this release for gen_js_api!

@mseri
Copy link
Member

mseri commented Jul 14, 2025

@NathanReb
Copy link
Contributor Author

Ah right, that's on me!

These are expected as we updated our pprintast copy, which unfortunately prints those differently, but I should have added upper bounds.

To be a bit more specific, gen_js_api tests already break with 0.36.0. I think this was not caught back then because it was simply not compatible with 0.36.0 at all.

I'm not sure what the right fix should be here. gen_js_api.1.1.4 is not compatible with ppxlib >= 0.36.0. gen_js_api.1.1.5 builds with ppxlib >= 0.36.0 but the tests won't work:

  • with ppxlib.0.36.0: the output is entirely wrong because our pprintast was bugged
  • with ppxlib.0.36.1: the output is slightly off because our pprintast was properly updated but prints ASTs slightly differently then before (just as the compiler does if I'm not mistaken).

To put it simply, gen_js_api1.1.5 test won't ever work. We'll have to wait for a new release that properly updates the tests expected output.

I'll look into the fstar failures!

CHANGES:

- Fix ppxlib driver's AST to source printer. Our copy of pprintast was not
  properly updated which resulted in incorrect printing of value bindings'
  constraints (ocaml-ppx/ppxlib#585, @NathanReb)
@NathanReb NathanReb force-pushed the release-ppxlib-0.36.1 branch from 4deebea to 9d82d8d Compare July 15, 2025 14:49
@NathanReb
Copy link
Contributor Author

Removed the ppxlib-bench package, this was inadvertently added!

@NathanReb
Copy link
Contributor Author

NathanReb commented Jul 15, 2025

Ah my bad, misread the CI failures. It seems that there are two distinct problems here: the one mentioned above and the fact that pprintast spits out code that doesn't parse in 4.14 anymore. I'll investigate and see what we can do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants