Upper bound qcheck in prbnmcn-stats 0.0.2-0.0.8 #28154
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI for versions 0.0.3-0.0.8 is failing or timing out on FreeBSD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forthcoming QCheck 0.26 release in #28148 patches the
floatgenerators to avoid blind spots: c-cube/qcheck#350.The CI run for the release however revealed such a blind spot, causing a
prbnmcn-statsQCheck test to start failing when run with QCheck 0.26:https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/c715a95fe87d4397d1f0658b2ae5acd528de705e
This PR therefore adds an upper bound of
qcheckforprbnmcn-statsfor already existing releases, so that their tests run predictably.I've filed an upstream PR to restore the property for the next
prbnmcn-statsrelease: igarnier/prbnmcn-stats#5