Skip to content

[new release] fast_bitvector (0.1.0.1) #28002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

smuenzel
Copy link
Contributor

@smuenzel smuenzel commented Jun 9, 2025

A bitvector library

CHANGES:
  • New, more clear, sexp representation
  • Better error messages for safe functions
  • Fix big-endian architecture compatibility
  • Remove returned bitvector in ops, user is now required to track it themselves
  • Use ~dst instead of ~result
  • Add Allocate variant of all ops in a submodule
  • Allow equality check between different-length bitvectors

@smuenzel smuenzel marked this pull request as draft June 9, 2025 02:38
@smuenzel smuenzel force-pushed the release-fast_bitvector-0.1.0 branch from 0844c20 to fe7247f Compare June 9, 2025 03:59
@smuenzel smuenzel changed the title [new release] fast_bitvector (0.1.0) [new release] fast_bitvector (0.1.0.1) Jun 9, 2025
@smuenzel
Copy link
Contributor Author

smuenzel commented Jun 9, 2025

I guess I'm hitting ocurrent/opam-repo-ci#441 here?

@ivnhk
Copy link

ivnhk commented Jun 9, 2025

Hey @smuenzel

You're right. We're currently investigating what's happening

@smuenzel smuenzel force-pushed the release-fast_bitvector-0.1.0 branch from fe7247f to 2dd389e Compare June 10, 2025 01:31
@smuenzel smuenzel marked this pull request as ready for review June 10, 2025 01:32
@ivnhk
Copy link

ivnhk commented Jun 10, 2025

The failing Windows build seems to be a recurring issue. I saw it on several PRs as well: #28012 and #28009.

I suppose it's not the packages' problems.

@ivnhk ivnhk self-requested a review June 10, 2025 18:26
CHANGES:

- Simplify append, add test
@smuenzel smuenzel force-pushed the release-fast_bitvector-0.1.0 branch from 2dd389e to 0dba09b Compare June 12, 2025 09:18
@shonfeder
Copy link
Contributor

@ivnhk, yep it was #28007!

Thanks for the review here :)

Thanks for publishing your updates, @smuenzel !

@shonfeder shonfeder merged commit 3c044b9 into ocaml:master Jun 12, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants