Release conf-libelf #27922
Release conf-libelf #27922
Conversation
There was a problem hiding this comment.
Thanks for the PR! 😃 🙏
Here's a couple of comments - incl. a missing dependency, which I believe is the cause of lots of the CI red lights.
It should also be possible to extend the PR a bit further, e.g.,
- to support Alpine https://pkgs.org/download/libelf
- to support macPorts https://ports.macports.org/port/libelf/
| bug-reports: "https://github.com/ocaml/opam-repository/issues" | ||
| build: ["pkg-config" "--exists" "libelf"] | ||
| depexts: [ | ||
| ["libelf-dev"] {os-family = "debian"} |
There was a problem hiding this comment.
| ["libelf-dev"] {os-family = "debian"} | |
| ["libelf-dev"] {os-family = "debian" | os-family = "ubuntu"} |
Otherwise this is going to fail on
- Ubuntu (see this Matrix: https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values) and
- Linux distributions derived from Ubuntu. One example is Linux Mint
| ] | ||
| synopsis: "Virtual package relying on libelf" | ||
| description: | ||
| "This package can only install if libelf is installed on the system." |
There was a problem hiding this comment.
| "This package can only install if libelf is installed on the system." | |
| "This package can only install if libelf is installed on the system." | |
| depends: ["conf-pkg-config" {build}] |
The package test depends on pkg-config, so this should state a dependency on it.
This is the reason for CI failures # [ERROR] Command not found: pkg-config.
|
@jmid Thank you for your feedback on this PR, and for identifying improvements to get it working on the different operating systems! I've committed your feedback, could you please let me know if this is enough? |
There was a problem hiding this comment.
Thanks, this is shaping up nicely with lots of green CI lights! 🙂
I see failures on Alpine, Fedora, and OpenSuse, which I think can be handled without too much effort, ensure broad support, and will save us from having to revise this repeatedly. I therefore suggest a couple of small changes to handle those platforms.
With luck, with these latest changes we are down to just a Windows failure, which I think is fair to leave for later.
In case someone is interested, I figured out one can search pkgs.org for the relevant .pc file, in this case: https://pkgs.org/search/?q=libelf.pc
Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
|
@jmid thanks again for your addition to this! I've just committed your changes using the web interface. Please let me know if this is sufficient! :) |
Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
Add conf-libelf virtual package for libelf.