[new release] reason (2 packages) (3.12.0) #26271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES:
- Add `\u{hex-escape}` syntax (@anmonteiro,
[reasonml/reason#2738](reasonml/reason#2738))
- Support local open and let bindings (@SanderSpies) [reasonml/reason#2716](reasonml/reason#2716)
- outcome printer: change the printing of `@bs.*` to `@mel.*` (@anmonteiro, [reasonml/reason#2755](reasonml/reason#2755))
- Fix outcome printing of optional arguments on OCaml 5.2 (@anmonteiro, [reasonml/reason#2753](reasonml/reason#2753))
- support parsing and printing of `external%extension` (@anmonteiro, [reasonml/reason#2750](reasonml/reason#2750), [reasonml/reason#2766](reasonml/reason#2766), [reasonml/reason#2767](reasonml/reason#2767))
- install `refmt` manpage (@anmonteiro, [reasonml/reason#2760](reasonml/reason#2760))
- add support for parsing / printing of refutation clause in `switch` (@anmonteiro, [reasonml/reason#2765](reasonml/reason#2765))
- support `let%ppx` in signatures (@anmonteiro, [reasonml/reason#2770](reasonml/reason#2770))
raphael-proust
added a commit
that referenced
this pull request
Jul 24, 2024
There is a failure in the CI of #26271 which seem to be related to server-reason-react. When checking the revdeps `server-reason-react.0.3.0`, the following type mismatch happens. ``` # File "packages/melange.js/Js.ml", line 496, characters 44-73: # 496 | let fromString : string -> t = fun str -> Quickjs.RegExp.compile str "" # ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ # Error: This expression has type # "(Quickjs.RegExp.t, # [ `Invalid_escape_sequence # | `Malformed_unicode_char # | `Nothing_to_repeat # | `Unexpected_end # | `Unknown of string ] * string) # Stdlib.result" # but an expression was expected of type "t" = "Quickjs.RegExp.t" ``` ping @davesnx
Co-authored-by: Raphaël Proust <raphael-proust@users.noreply.github.com>
|
@mseri thanks for bumping the ocaml constraint but I think we want to find a fix upstream to still support OCaml 4.03. I'll update our decision here in a few days. |
|
As you prefer. I put a do not merge tag to avoid mistakes from our side. If it can help, all the actively maintained linux distributions are shipping 4.08+ at this point |
that makes sense, let's go ahead and merge then. we can drop support for 4.03 / 4.04 / 4.05 |
|
Do you know if this error is related to the release? |
|
@mseri that's not related to this release, and was fixed in Melange 4.0.1-52. we could likely even disable that release. |
|
disabled in #26301 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: Syntax & Toolchain for OCaml
CHANGES:
\u{hex-escape}syntax (@anmonteiro,reasonml/reason#2738)
@bs.*to@mel.*(@anmonteiro, reasonml/reason#2755)external%extension(@anmonteiro, reasonml/reason#2750, reasonml/reason#2766, reasonml/reason#2767)refmtmanpage (@anmonteiro, reasonml/reason#2760)switch(@anmonteiro, reasonml/reason#2765)let%ppxin signatures (@anmonteiro, reasonml/reason#2770)