Added new version 1.4.2 for gappa and changed URL for older gappa #25896
Conversation
packages/gappa/gappa.1.3.5/opam
Outdated
| } | ||
| extra-files: [ |
There was a problem hiding this comment.
Why are these gone? Have they been integrated in the new tarballs?
We are reluctant to tarball changes in the repository nowadays (See https://github.com/ocaml/opam-repository/wiki/Policies#11-changes-to-a-packages-source-archive-are-prohibited).
Before merging this, I need to obtain the old tarballs and manually verify that there was no change between the old and the new. If possible, I'd reinstate the old tarballs at the new urls, If you don't have them, you can likely find them following https://github.com/ocaml/opam-repository/wiki/FAQ#how-to-find-lost-archives-of-packages
There was a problem hiding this comment.
@mseri : I found that the extra_files section is not required for patch files - I guess opam trusts them as much as the opam file if they come from the same source, so its doesn't require a checksum. So I tend to remove the extra_files section when I clean up opam files.
The old tarballs are still there - both new and old locations are OK. The newer versions are the same. The version 1.3.5 defers, but it should be a minor difference. I have seen this in the past that on the fly generated tar balls change their checksum.
Anyway according to the author (Guillaume Melquiond) the new locations are the official locations. See also https://gappa.gitlabpages.inria.fr/releases/.
There was a problem hiding this comment.
For the old releases, I'd rather use the old tarballs. If they cannot be replaced on the new locations, I suggest to upload them on the opam-source-archives repository and link them from there
|
Please don't merge as yet, I want to have a look at the CI errors first. |
| dev-repo: "git+https://gitlab.inria.fr/gappa/gappa.git" | ||
| license: "CECILL-2.1" | ||
| patches: [ | ||
| "0001-Added-configure-for-c-11.patch" |
There was a problem hiding this comment.
Is this the same as https://raw.githubusercontent.com/ocaml/opam-source-archives/main/patches/gappa/0001-Added-configure-for-c-11.patch ?
If so, please use the remote one, otherwise we need to upload the new patch there as well and link it from there (with a checksum)
There was a problem hiding this comment.
I guess so. I was not aware of this mechanism. I am the original author of this patch and used to copy it from version to version. Can you point me to the documentation of this "auto extract patches from commits and put it somewhere else" mechanism, so that I know, what I am doing?
|
@MSoegtropIMC I don't see the CI failures (except the rebase that needs to be done) ? Or did you mean something else ? |
|
@rtetley : when CI did run last, it failed on some Unix platforms. |
…sion to a more stable source (the hash changed recently for 1.3.5)
MSoegtropIMC
force-pushed
the
update-gappa
branch
from
7dfe164
to
563ed62
Compare
This PR adds new version 1.4.2 for gappa - a tool to automatically generate arithmetic proofs.
I also changed the tar ball URLs for all older versions to a stored and not on the fly generated source. Recently the hash of gappa 1.3.5 changed magically (this happens sometimes on github).
The C++ 11 config patch should not be required any more for version 1.4.2, but we need to see what opam CI says to this.