Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-systemd 1.3 #22536

Merged
merged 4 commits into from
Nov 25, 2022
Merged

ocaml-systemd 1.3 #22536

merged 4 commits into from
Nov 25, 2022

Conversation

juergenhoetzel
Copy link
Contributor

  • Add compatibility with OCaml 5
  • Build library using dune

- Add compatibility with OCaml 5
- Build library using dune
Comment on lines +20 to +23
depexts: [
["libsystemd-dev"] {os-family = "debian"}
["systemd-devel"] { os-family = "suse" | os-family = "opensuse" | os-family = "fedora"}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future it would be nice to replace this by a conf-libsystemd package to make it easier to maintain.

@kit-ty-kate
Copy link
Member

#=== ERROR while compiling ocaml-systemd.1.3 ==================================#
# context              2.2.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.02.3 | pinned(https://github.com/juergenhoetzel/ocaml-systemd/archive/1.3.tar.gz)
# path                 ~/.opam/4.02/.opam-switch/build/ocaml-systemd.1.3
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ocaml-systemd -j 31
# exit-code            1
# env-file             ~/.opam/log/ocaml-systemd-7-f3820a.env
# output-file          ~/.opam/log/ocaml-systemd-7-f3820a.out
### output ###
# Error: I don't know about package ocaml-systemd (passed through
# --only-packages)

There is a mismatch between the name of the package and the name of the library. Is this expected?

Note that before my addition of -p name the package would have installed nothing at all.

@juergenhoetzel
Copy link
Contributor Author

juergenhoetzel commented Nov 24, 2022

There is a mismatch between the name of the package and the name of the library. Is this expected?

No, i guess is should have omitted the prefix when submitting the first version of ocaml-systemd back in 2015.

I just hardcoded the systemd name in the amended commit.

@kit-ty-kate
Copy link
Member

kit-ty-kate commented Nov 25, 2022

LGTM once CI finishes. Could you return the fixes in the opam file upstream to that they can be taken into account for next time?

Note also, another solution for future releases could also be to create a new systemd package and create a ocaml-systemd.transition package that points to it. Several packages made similar moves in the past and it avoids the extra annoying dune install (slower and more error prone than what opam does)

@kit-ty-kate
Copy link
Member

Thanks

@kit-ty-kate kit-ty-kate merged commit 56a0310 into ocaml:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants