-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocaml-systemd 1.3 #22536
ocaml-systemd 1.3 #22536
Conversation
juergenhoetzel
commented
Nov 20, 2022
- Add compatibility with OCaml 5
- Build library using dune
1899a5b
to
7e1e8db
Compare
- Add compatibility with OCaml 5 - Build library using dune
7e1e8db
to
740ec91
Compare
depexts: [ | ||
["libsystemd-dev"] {os-family = "debian"} | ||
["systemd-devel"] { os-family = "suse" | os-family = "opensuse" | os-family = "fedora"} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future it would be nice to replace this by a conf-libsystemd
package to make it easier to maintain.
There is a mismatch between the name of the package and the name of the library. Is this expected? Note that before my addition of |
b004f80
to
c6ab165
Compare
No, i guess is should have omitted the prefix when submitting the first version of ocaml-systemd back in 2015. I just hardcoded the |
LGTM once CI finishes. Could you return the fixes in the opam file upstream to that they can be taken into account for next time? Note also, another solution for future releases could also be to create a new |
Thanks |