-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] rtop and reason (3.8.1) #21677
Conversation
CHANGES: - (Internal) Rename: Reason_migrate_parsetree -> Reason_omp (@ManasJayanth) [reasonml/reason#2666](reasonml/reason#2666) - Add support for OCaml 5.0 (@EduardoRFS and @anmonteiro) [reasonml/reason#2667](reasonml/reason#2667)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changelog includes "Add support for OCaml 5.0" so I’m guessing that was an oversight
Indeed, thanks for fixing! I'll return the fixes upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your dune-project file says you require 2.3
I clearly messed up the release. Will re-submit. |
Really? It felt like only a couple of missing constraints left to do |
I didn't intend to bump the release lower bounds. Reason should work on 4.03. |
It worked on 4.03, it just failed with some older versions of its dependencies, the only thing to do is to detect which ones |
Reason toplevel
CHANGES: