Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] rtop and reason (3.8.1) #21677

Closed
wants to merge 3 commits into from

Conversation

anmonteiro
Copy link
Contributor

Reason toplevel

CHANGES:

CHANGES:

- (Internal) Rename: Reason_migrate_parsetree -> Reason_omp (@ManasJayanth) [reasonml/reason#2666](reasonml/reason#2666)
- Add support for OCaml 5.0 (@EduardoRFS and @anmonteiro) [reasonml/reason#2667](reasonml/reason#2667)
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changelog includes "Add support for OCaml 5.0" so I’m guessing that was an oversight

packages/reason/reason.3.8.1/opam Outdated Show resolved Hide resolved
packages/rtop/rtop.3.8.1/opam Outdated Show resolved Hide resolved
@anmonteiro
Copy link
Contributor Author

Indeed, thanks for fixing! I'll return the fixes upstream.

Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your dune-project file says you require 2.3

packages/reason/reason.3.8.1/opam Outdated Show resolved Hide resolved
packages/rtop/rtop.3.8.1/opam Outdated Show resolved Hide resolved
@anmonteiro
Copy link
Contributor Author

I clearly messed up the release. Will re-submit.

@anmonteiro anmonteiro closed this Jun 28, 2022
@anmonteiro anmonteiro deleted the release-rtop-3.8.1 branch June 28, 2022 18:43
@kit-ty-kate
Copy link
Member

Really? It felt like only a couple of missing constraints left to do

@anmonteiro
Copy link
Contributor Author

I didn't intend to bump the release lower bounds. Reason should work on 4.03.

@kit-ty-kate
Copy link
Member

It worked on 4.03, it just failed with some older versions of its dependencies, the only thing to do is to detect which ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants