Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package frenetic.5.0.5 #19561

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

jnfoster
Copy link
Contributor

frenetic.5.0.5

The Frenetic Programming Language and Runtime System



🐫 Pull-request generated by opam-publish v2.1.0

@mseri
Copy link
Member

mseri commented Sep 15, 2021

All builds are failing with

#       ocamlc src/syntax/.frenetic_ppx.objs/byte/frenetic_ppx__Ppx.{cmi,cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.12/bin/ocamlc.opt -w -40 -g -bin-annot -I src/syntax/.frenetic_ppx.objs/byte -I /home/opam/.opam/4.12/lib/astring -I /home/opam/.opam/4.12/lib/base -I /home/opam/.opam/4.12/lib/base/base_internalhash_types -I /home/opam/.opam/4.12/lib/base/caml -I /home/opam/.opam/4.12/lib/base/md5 -I /home/opam/.opam/4.12/lib/base/shadow_stdlib -I /home/opam/.opam/4.12/lib/base64 -I /home/opam/.opam/4.12/lib/base_bigstring -I /home/opam/.opam/4.12/lib/base_quickcheck -I /home/opam/.opam/4.12/lib/bigarray-compat -I /home/opam/.opam/4.12/lib/bin_prot -I /home/opam/.opam/4.12/lib/bin_prot/shape -I /home/opam/.opam/4.12/lib/biniou -I /home/opam/.opam/4.12/lib/bytes -I /home/opam/.opam/4.12/lib/core -I /home/opam/.opam/4.12/lib/core/error_checking_mutex -I /home/opam/.opam/4.12/lib/core_kernel -I /home/opam/.opam/4.12/lib/core_kernel/base_for_tests -I /home/opam/.opam/4.12/lib/core_kernel/caml_unix -I /home/opam/.opam/4.12/lib/core_kernel/flags -I /home/opam/.opam/4.12/lib/core_kernel/version_util -I /home/opam/.opam/4.12/lib/cstruct -I /home/opam/.opam/4.12/lib/cstruct-sexp -I /home/opam/.opam/4.12/lib/domain-name -I /home/opam/.opam/4.12/lib/easy-format -I /home/opam/.opam/4.12/lib/fieldslib -I /home/opam/.opam/4.12/lib/fmt -I /home/opam/.opam/4.12/lib/gen -I /home/opam/.opam/4.12/lib/ipaddr -I /home/opam/.opam/4.12/lib/jane-street-headers -I /home/opam/.opam/4.12/lib/macaddr -I /home/opam/.opam/4.12/lib/menhirLib -I /home/opam/.opam/4.12/lib/ocaml-compiler-libs/common -I /home/opam/.opam/4.12/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/4.12/lib/ocaml-migrate-parsetree -I /home/opam/.opam/4.12/lib/ocaml/compiler-libs -I /home/opam/.opam/4.12/lib/ocaml/threads -I /home/opam/.opam/4.12/lib/ocamlgraph -I /home/opam/.opam/4.12/lib/open -I /home/opam/.opam/4.12/lib/parsexp -I /home/opam/.opam/4.12/lib/ppx_assert/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_bench/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_compare/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_derivers -I /home/opam/.opam/4.12/lib/ppx_deriving/runtime -I /home/opam/.opam/4.12/lib/ppx_enumerate/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_expect/collector -I /home/opam/.opam/4.12/lib/ppx_expect/common -I /home/opam/.opam/4.12/lib/ppx_expect/config -I /home/opam/.opam/4.12/lib/ppx_expect/config_types -I /home/opam/.opam/4.12/lib/ppx_hash/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_here/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_inline_test/config -I /home/opam/.opam/4.12/lib/ppx_inline_test/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_module_timer/runtime -I /home/opam/.opam/4.12/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.12/lib/ppxlib -I /home/opam/.opam/4.12/lib/ppxlib/ast -I /home/opam/.opam/4.12/lib/ppxlib/print_diff -I /home/opam/.opam/4.12/lib/ppxlib/stdppx -I /home/opam/.opam/4.12/lib/ppxlib/traverse_builtins -I /home/opam/.opam/4.12/lib/result -I /home/opam/.opam/4.12/lib/sedlex -I /home/opam/.opam/4.12/lib/seq -I /home/opam/.opam/4.12/lib/sexplib -I /home/opam/.opam/4.12/lib/sexplib/unix -I /home/opam/.opam/4.12/lib/sexplib0 -I /home/opam/.opam/4.12/lib/spawn -I /home/opam/.opam/4.12/lib/splittable_random -I /home/opam/.opam/4.12/lib/stdio -I /home/opam/.opam/4.12/lib/stdlib-shims -I /home/opam/.opam/4.12/lib/tcpip -I /home/opam/.opam/4.12/lib/tcpip/unix -I /home/opam/.opam/4.12/lib/time_now -I /home/opam/.opam/4.12/lib/timezone -I /home/opam/.opam/4.12/lib/typerep -I /home/opam/.opam/4.12/lib/uchar -I /home/opam/.opam/4.12/lib/variantslib -I /home/opam/.opam/4.12/lib/yojson -I src/lib/kernel/.frenetic_kernel.objs/byte -I src/lib/netkat/.frenetic_netkat.objs/byte -no-alias-deps -open Frenetic_ppx -o src/syntax/.frenetic_ppx.objs/byte/frenetic_ppx__Ppx.cmo -c -impl src/syntax/ppx.pp.ml)
# File "src/syntax/ppx.ml", line 24, characters 18-46:
# 24 |   | Pexp_constant (Pconst_string (s, Some "")) ->
#                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: The constructor Pconst_string expects 3 argument(s),
#        but is applied here to 2 argument(s)
#     ocamlopt src/lib/netkat/.frenetic_netkat.objs/native/frenetic_netkat__Lexer.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.12/bin/ocamlopt.opt -w -40 -safe-string -g -I src/lib/netkat/.frenetic_netkat.objs/byte -I src/lib/netkat/.frenetic_netkat.objs/native -I /home/opam/.opam/4.12/lib/astring -I /home/opam/.opam/4.12/lib/base -I /home/opam/.opam/4.12/lib/base/base_internalhash_types -I /home/opam/.opam/4.12/lib/base/caml -I /home/opam/.opam/4.12/lib/base/md5 -I /home/opam/.opam/4.12/lib/base/shadow_stdlib -I /home/opam/.opam/4.12/lib/base64 -I /home/opam/.opam/4.12/lib/base_bigstring -I /home/opam/.opam/4.12/lib/base_quickcheck -I /home/opam/.opam/4.12/lib/bigarray-compat -I /home/opam/.opam/4.12/lib/bin_prot -I /home/opam/.opam/4.12/lib/bin_prot/shape -I /home/opam/.opam/4.12/lib/biniou -I /home/opam/.opam/4.12/lib/bytes -I /home/opam/.opam/4.12/lib/core -I /home/opam/.opam/4.12/lib/core/error_checking_mutex -I /home/opam/.opam/4.12/lib/core_kernel -I /home/opam/.opam/4.12/lib/core_kernel/base_for_tests -I /home/opam/.opam/4.12/lib/core_kernel/caml_unix -I /home/opam/.opam/4.12/lib/core_kernel/flags -I /home/opam/.opam/4.12/lib/core_kernel/version_util -I /home/opam/.opam/4.12/lib/cstruct -I /home/opam/.opam/4.12/lib/cstruct-sexp -I /home/opam/.opam/4.12/lib/domain-name -I /home/opam/.opam/4.12/lib/easy-format -I /home/opam/.opam/4.12/lib/fieldslib -I /home/opam/.opam/4.12/lib/fmt -I /home/opam/.opam/4.12/lib/gen -I /home/opam/.opam/4.12/lib/ipaddr -I /home/opam/.opam/4.12/lib/jane-street-headers -I /home/opam/.opam/4.12/lib/macaddr -I /home/opam/.opam/4.12/lib/menhirLib -I /home/opam/.opam/4.12/lib/ocaml/compiler-libs -I /home/opam/.opam/4.12/lib/ocaml/threads -I /home/opam/.opam/4.12/lib/ocamlgraph -I /home/opam/.opam/4.12/lib/open -I /home/opam/.opam/4.12/lib/parsexp -I /home/opam/.opam/4.12/lib/ppx_assert/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_bench/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_compare/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_deriving/runtime -I /home/opam/.opam/4.12/lib/ppx_enumerate/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_expect/collector -I /home/opam/.opam/4.12/lib/ppx_expect/common -I /home/opam/.opam/4.12/lib/ppx_expect/config -I /home/opam/.opam/4.12/lib/ppx_expect/config_types -I /home/opam/.opam/4.12/lib/ppx_hash/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_here/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_inline_test/config -I /home/opam/.opam/4.12/lib/ppx_inline_test/runtime-lib -I /home/opam/.opam/4.12/lib/ppx_module_timer/runtime -I /home/opam/.opam/4.12/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.12/lib/result -I /home/opam/.opam/4.12/lib/sedlex -I /home/opam/.opam/4.12/lib/seq -I /home/opam/.opam/4.12/lib/sexplib -I /home/opam/.opam/4.12/lib/sexplib/unix -I /home/opam/.opam/4.12/lib/sexplib0 -I /home/opam/.opam/4.12/lib/spawn -I /home/opam/.opam/4.12/lib/splittable_random -I /home/opam/.opam/4.12/lib/stdio -I /home/opam/.opam/4.12/lib/stdlib-shims -I /home/opam/.opam/4.12/lib/tcpip -I /home/opam/.opam/4.12/lib/tcpip/unix -I /home/opam/.opam/4.12/lib/time_now -I /home/opam/.opam/4.12/lib/timezone -I /home/opam/.opam/4.12/lib/typerep -I /home/opam/.opam/4.12/lib/uchar -I /home/opam/.opam/4.12/lib/variantslib -I /home/opam/.opam/4.12/lib/yojson -I src/lib/kernel/.frenetic_kernel.objs/byte -I src/lib/kernel/.frenetic_kernel.objs/native -intf-suffix .ml -no-alias-deps -open Frenetic_netkat -o src/lib/netkat/.frenetic_netkat.objs/native/frenetic_netkat__Lexer.cmx -c -impl src/lib/netkat/Lexer.pp.ml)
# File "_none_", line 1:
# Error: Unbound value Sedlexing.__private__next_int

@jnfoster
Copy link
Contributor Author

All builds are failing with [snipped...]

So sorry. I seem to have had an outdated version of ppxlib installed. Should know better than to fire-and-forget at 3am :-)

@mseri
Copy link
Member

mseri commented Oct 12, 2021

@jnfoster what is the status of this, shuld we close it?

@avsm
Copy link
Member

avsm commented Oct 27, 2021

@jnfoster which version of ppxlib did you have installed? We can just add an upper bound on the package description here and merge this. A future revision can include the latest ASTs.

@jnfoster jnfoster closed this Nov 5, 2021
@jnfoster jnfoster reopened this Nov 5, 2021
@jnfoster jnfoster force-pushed the opam-publish-frenetic.5.0.5 branch 2 times, most recently from 26ac61d to 614a4fd Compare November 5, 2021 02:00
@jnfoster
Copy link
Contributor Author

jnfoster commented Nov 5, 2021

Hi! I removed some fragile and hard to maintain PPX code that was rarely used, and updated dependencies in the .opam file. Let's see if this works...

packages/frenetic/frenetic.5.0.5/opam Outdated Show resolved Hide resolved
packages/frenetic/frenetic.5.0.5/opam Outdated Show resolved Hide resolved
packages/frenetic/frenetic.5.0.5/opam Outdated Show resolved Hide resolved
@jnfoster
Copy link
Contributor Author

jnfoster commented Nov 5, 2021

🙏 You are very kind to review and repair the disorganized commits from a busy professor.

@jnfoster
Copy link
Contributor Author

jnfoster commented Nov 5, 2021

Many of the CI builds are failing because of an MD5 sum. I created my PR with opam publish. Did I also need to do something else? Sorry for being a newbie...

@kit-ty-kate
Copy link
Member

Many of the CI builds are failing because of an MD5 sum. I created my PR with opam publish. Did I also need to do something else? Sorry for being a newbie...

The 5.0.5 tag used for the archive has been force-pushed a couple of hours ago after your last change here, so the checksum is different from the one submitted by opam publish. Could you either force-push it back to the original or update the checksum in this PR?

@jnfoster
Copy link
Contributor Author

jnfoster commented Nov 9, 2021

Seems like the CI is stalled only on the MacOS / Homebrew jobs.

2021-11-08 21:44.48: Waiting for resource in pool OCluster

Is there anything that can be done to get this unstuck? Did the project run out of resources for the week/month/year?

@kit-ty-kate
Copy link
Member

Yeah, the macOS runners are stuck. We can merge anyway i think. Thanks!

@kit-ty-kate kit-ty-kate merged commit c574489 into ocaml:master Nov 9, 2021
@jnfoster
Copy link
Contributor Author

jnfoster commented Nov 9, 2021

Woohoo! Thank you again for patiently reviewing this and helping me get everything in order. It's great to have Frenetic building in opam again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants