-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zelus and zelus-gtk 2.1 packages #17942
Conversation
I don't understand why the build keeps failing on archlinux. I tried to add the missing dependencies, but:
Am I missing something? |
Ok, making progress... Thanks for you help. |
packages/zelus/zelus.2.1/opam
Outdated
maintainer: ["Marc Pouzet <marc.pouzet@ens.fr>"] | ||
homepage: "http://zelus.di.ens.fr" | ||
doc: "http://zelus.di.ens.fr/man/" | ||
bug-reports: "https://gitlab.inria.fr/parkas/zelus/-/issues" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this link is not accessible
packages/zelus/zelus.2.1/opam
Outdated
bug-reports: "https://gitlab.inria.fr/parkas/zelus/-/issues" | ||
depends: [ | ||
"ocaml" {>= "4.08.1"} | ||
"dune" {>= "2.6" & build} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dune should not be tagged as a build dependency (see ocaml/dune#2147)
depends: [ | ||
"ocaml" {>= "4.08.1"} | ||
"dune" {>= "2.6"} | ||
"zelus" {= version} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are planning to release the two packages together, I would highly encourage you to use {= version}
. If not, feel free to revert this change.
"dune" {>= "2.6"} | ||
"zelus" {= version} | ||
"lablgtk" | ||
"conf-gtksourceview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtksourceview-2.0 is getting really old and is not supported by an increasing number of distributions, it might be more future-proof to switch to gtksourceview3 in next release
The PR should be good to go after that. Could you review my change and return them in the opam file upstream if they seem correct to you? |
Thanks a lot! |
Looks good now, thanks! (note that gtk2 itself is also quite old, though better supported across distributions than its sublibraries) |
These packages contains the Zelus compiler (package zelus) and optional gtk dependent librairies (zelus-gtk)
https://zelus.di.ens.fr/