Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zelus and zelus-gtk 2.1 packages #17942

Merged
merged 12 commits into from
Jan 12, 2021
Merged

Add zelus and zelus-gtk 2.1 packages #17942

merged 12 commits into from
Jan 12, 2021

Conversation

gbdrt
Copy link
Contributor

@gbdrt gbdrt commented Jan 8, 2021

These packages contains the Zelus compiler (package zelus) and optional gtk dependent librairies (zelus-gtk)
https://zelus.di.ens.fr/

@camelus
Copy link
Contributor

camelus commented Jan 8, 2021

Commit: b596a98

Hello @gbdrt! I believe this is your first contribution here. Please be nice, reviewers!

☀️ All lint checks passed b596a98
  • These packages passed lint tests: zelus-gtk.2.1, zelus.2.1

☀️ Installability check (+2)
  • new installable packages (2): zelus.2.1 zelus-gtk.2.1

@gbdrt
Copy link
Contributor Author

gbdrt commented Jan 8, 2021

I don't understand why the build keeps failing on archlinux. I tried to add the missing dependencies, but:

  • I don't understand why these packages are required
  • The build is still failing with these explicit depexts.

Am I missing something?

@gbdrt
Copy link
Contributor Author

gbdrt commented Jan 8, 2021

Ok, making progress...
I removed the graphics dependencies, but now it is complaining about a missing gtk+.
Do I need to add it as a depexts? It looks like other packages depending on lablgtk do not need this.

Thanks for you help.

@gbdrt gbdrt changed the title Add zelus and zelus-gtk packages Add zelus and zelus-gtk 2.1 packages Jan 11, 2021
maintainer: ["Marc Pouzet <marc.pouzet@ens.fr>"]
homepage: "http://zelus.di.ens.fr"
doc: "http://zelus.di.ens.fr/man/"
bug-reports: "https://gitlab.inria.fr/parkas/zelus/-/issues"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is not accessible

bug-reports: "https://gitlab.inria.fr/parkas/zelus/-/issues"
depends: [
"ocaml" {>= "4.08.1"}
"dune" {>= "2.6" & build}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dune should not be tagged as a build dependency (see ocaml/dune#2147)

depends: [
"ocaml" {>= "4.08.1"}
"dune" {>= "2.6"}
"zelus" {= version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are planning to release the two packages together, I would highly encourage you to use {= version}. If not, feel free to revert this change.

"dune" {>= "2.6"}
"zelus" {= version}
"lablgtk"
"conf-gtksourceview"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtksourceview-2.0 is getting really old and is not supported by an increasing number of distributions, it might be more future-proof to switch to gtksourceview3 in next release

@kit-ty-kate
Copy link
Member

The PR should be good to go after that. Could you review my change and return them in the opam file upstream if they seem correct to you?

@gbdrt
Copy link
Contributor Author

gbdrt commented Jan 12, 2021

Thanks a lot!
I just pushed the updated version (with small fixes in the descriptions).
I also removed the dependencies to gtksourceview. We do not really need it, I wanted to see if it could solve the build failure on archlinux.

@kit-ty-kate
Copy link
Member

Looks good now, thanks! (note that gtk2 itself is also quite old, though better supported across distributions than its sublibraries)

@kit-ty-kate kit-ty-kate merged commit 9194790 into ocaml:master Jan 12, 2021
@gbdrt gbdrt deleted the add-pkg-zelus branch January 13, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants