Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] uri-re, uri-sexp and uri (3.2.0) #17409

Closed
wants to merge 1 commit into from

Conversation

dinosaure
Copy link
Contributor

An RFC3986 URI/URL parsing library

CHANGES:

CHANGES:

* sexp: use the sexplib v0.13 ppx directives (@avsm, mirage/ocaml-uri#143).
* rework the URI parser with `angstrom` (@anmonteiro, review @avsm & @dinosaure, mirage/ocaml-uri#142).
* add simple fuzzer tests between `angstrom` parser and _legacy_ parser (with `re.posix`, mirage/ocaml-uri#142)
* add support of modifying pct encoding (with a custom one) (@orbitz, review @anmonteiro, @tmcgilchrist, @avsm & @dinosaure, mirage/ocaml-uri#147)
* allow the selection of generic set of safe characters (with `Generic`) (@madroach, review @dinosaure, mirage/ocaml-uri#141)
@camelus
Copy link
Contributor

camelus commented Oct 14, 2020

Commit: 219e45d

A pull request by opam-seasoned @dinosaure.

☀️ All lint checks passed 219e45d
  • These packages passed lint tests: uri-re.3.2.0, uri-sexp.3.2.0, uri.3.2.0

☀️ Installability check (+3)
  • new installable packages (3): uri.3.2.0 uri-re.3.2.0 uri-sexp.3.2.0

@mseri
Copy link
Member

mseri commented Oct 14, 2020

Since this comes with plenty of dependencies, I'll wait for the big CI run before merging

@avsm
Copy link
Member

avsm commented Oct 14, 2020

Sorry to not notice before @dinosaure, but this really needs to be 4.0.0 -- it's a rewrite of the implementation entirely, so I think the major should bump even if the interface is very similar. (the CI run here is of course still very useful)

@dinosaure
Copy link
Contributor Author

Close by #17411

@dinosaure dinosaure closed this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants