Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package shapefile.0.2.1 #17269

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

cyril-allignol
Copy link
Contributor

shapefile.0.2.1

A small library to read ESRI shapefiles



🐫 Pull-request generated by opam-publish v2.0.0

@camelus
Copy link
Contributor

camelus commented Sep 24, 2020

Commit: 25641da

@cyril-allignol has posted 2 contributions.

☀️ All lint checks passed 25641da
  • These packages passed lint tests: shapefile.0.2.1

☀️ Installability check (+1)
  • new installable packages (1): shapefile.0.2.1

@kit-ty-kate
Copy link
Member

Dune is not compatible with the {build} tag (see ocaml/dune#2147) and ocamlfind was not used anywhere so I removed it.
I also explicitly added the minimal required version of dune and ocaml in the dependencies, it'll be more simple to change things in the future if it's more explicit.

Could you return these changes in the opam file upstream so it can be taken for future releases?

Thanks!

@kit-ty-kate kit-ty-kate merged commit afdb9eb into ocaml:master Sep 25, 2020
@cyril-allignol
Copy link
Contributor Author

Dune is not compatible with the {build} tag (see ocaml/dune#2147) and ocamlfind was not used anywhere so I removed it.
I also explicitly added the minimal required version of dune and ocaml in the dependencies, it'll be more simple to change things in the future if it's more explicit.

Could you return these changes in the opam file upstream so it can be taken for future releases?

Done in the master branch. Thanks again for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants