Skip to content

Fix spurious space around parentheses #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2022
Merged

Fix spurious space around parentheses #832

merged 2 commits into from
Feb 22, 2022

Conversation

panglesd
Copy link
Collaborator

This fixes the spurious space around parentheses reported in #829:

val pf : Format.formatter -> ( 'a, Format.formatter, unit ) format -> 'a
val map : ( 'a -> 'b ) -> 'a list -> 'b list

are now rendered as ocamlformat would, that is:

val pf : Format.formatter -> ('a, Format.formatter, unit) format -> 'a
val map : ('a -> 'b) -> 'a list -> 'b list

@panglesd
fix spurious space around parentheses
be085e0 
Signed-off-by: Paul-Elliot <peada@free.fr>
Julow
Julow approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

For the type params, definitely not, but for the arrows, I wonder if that was on purpose ? @Drup

@Julow
Copy link
Collaborator

Julow commented Feb 21, 2022

And you need to promote the tests.

@panglesd
promoting tests after fixing spurious spaces
60843be 
Signed-off-by: Paul-Elliot <peada@free.fr>
@jonludlam jonludlam merged commit ef4cb3b into ocaml:master Feb 22, 2022
@jonludlam
Copy link
Member

Thanks!

@dbuenzli dbuenzli mentioned this pull request Feb 22, 2022
Closed
@jonludlam jonludlam mentioned this pull request Dec 13, 2022
Merged
mseri pushed a commit to ocaml/opam-repository that referenced this pull request Dec 13, 2022
@jonludlam
[new release] odoc (2.2.0)
bbb2a3c 
CHANGES:

Additions
- New unstable option `--as-json` for the HTML renderer that emits HTML
  fragments (preamble, content) together with metadata (table of contents,
  breadcrumbs, whether katex is used) in JSON format. (@sabine, ocaml/odoc#908)
- New maths support via `{m ... }` and `{math ... }` tags. (@giltho, @gpetiot, ocaml/odoc#886)
- Various optimisations (@jonludlam, ocaml/odoc#870, ocaml/odoc#883)
- Better handling of alerts and deprecation notices. (@panglesd, ocaml/odoc#828)
- Handle language tags on code blocks (@Julow, ocaml/odoc#848)

Bugfixes
- Shadowing issues (@jonludlam, ocaml/odoc#853)
- Layout fixes and improvements (@panglesd, ocaml/odoc#832, ocaml/odoc#839, ocaml/odoc#847)
- Handle comments on class constraints and inherit (@Julow, ocaml/odoc#844)
- Disable the missing root warning (@jonludlam, ocaml/odoc#881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julow Julow Julow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panglesd @Julow @jonludlam