fix line number off-by-one-error #736
Conversation
asavahista
changed the title
|
fixed the one test that was affected; the failing ci runs are the usual debian 4.02 to 4.05 - i'm assuming |
| @@ -1,9 +1,9 @@ | |||
| # References to pages and items in pages | |||
|
|
|||
| $ compile p.mld good_references.mli bad_references.mli | |||
| File "p.mld", line 6, characters 5-11: | |||
| File "p.mld", line 7, characters 5-11: | |||
There was a problem hiding this comment.
This test is wrong, these references should be changed to: (the errors will disappear)
{!Good_references} {!Good_references.t}
There was a problem hiding this comment.
This test and the other tests failing in CI will be fixed in #738
|
seems like not starting with a heading makes it stop completely (and not show any line numbers) - i'll just use some other error instead then |
asavahista
force-pushed
the
fix-line-number
branch
from
134ca1b to
737612e
Compare
|
(hopefully) removed the fix for the unrelated test which is now in #738 |
|
Slightly surprisingly, the examples for odoc-parser got this right. Surprising because the code was extracted from here :-) |
CHANGES: Breaking changes - Remove odoc-parser into a separate repository (@jonludlam, ocaml/odoc#700) Additions - OCaml 4.13 support (@Octachron, ocaml/odoc#687, ocaml/odoc#689) - Better errors/warnings (@Julow, ocaml/odoc#692, ocaml/odoc#717, ocaml/odoc#720, ocaml/odoc#732) - ModuleType 'Alias' support (@jonludlam, ocaml/odoc#703) - Improved test suite (@lubega-simon, ocaml/odoc#697) - Improved documentation (@lubega-simon, @jonludlam, ocaml/odoc#702, ocaml/odoc#733) - Strengthen module types (@jonludlam, ocaml/odoc#731) Bugs fixed - `uwt` now can be documented (@jonludlam, ocaml/odoc#708) - Fix resolution involving deeply nested substitutions (@jonludlam, ocaml/odoc#727) - Fix off-by-one error in error reporting (@asavahista, ocaml/odoc#736)
warning: not extensively tested. if others could also test that'd be great.
please let me know if i need to add regression tests (or anything else)
it's a very small and simple change so just committing to master and closing this also works