Update the representation of code blocks #711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
commented
Aug 3, 2021
src/model/comment.ml
Outdated
| @@ -40,7 +40,9 @@ type module_reference = { | |||
|
|
|||
| type nestable_block_element = | |||
| [ `Paragraph of paragraph | |||
| | `Code_block of string with_location option * string with_location | |||
| | `Code_block of | |||
| string with_location option * string with_location | |||
There was a problem hiding this comment.
The meaning of the first argument changed (from the whole metadata to just the language tag) but it wasn't used anywhere.
There was a problem hiding this comment.
I suggest turning it into a (new) record type.
Julow
force-pushed
the
upt-parser-meta
branch
from
fdd7103 to
d732aec
Compare
The representation of code blocks will change slightly. This doesn't make use of the language tag yet.
This needs to be reverted once odoc-parser is released.
Julow
force-pushed
the
upt-parser-meta
branch
from
d732aec to
6c0d8cd
Compare
|
We don't need to interpret that field yet. We don't need this for compatibility either: #742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The representation of code blocks will change slightly: ocaml-doc/odoc-parser#2
This doesn't make use of the language tag yet.