Remove use of /tmp from a test #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
added
the
no changelog
|
I'm not sure how this test is useful. It was introduced in #1081, so I guess it's about the computed content of the signature? |
panglesd
reviewed
Jun 16, 2025
test/xref2/fragmap.t/run.t
Outdated
| @@ -1,6 +1,4 @@ | |||
| $ ocamlc -c -bin-annot test.mli | |||
| $ odoc compile test.cmti | |||
| $ odoc link test.odoc | |||
There was a problem hiding this comment.
A low effort that makes the test more useful would be to print the content:
Suggested change
| $ odoc link test.odoc | |
| $ odoc link test.odoc | |
| $ odoc_print test.odocl |
A better version would be to only show what we are interested in in this test and explain what we test, but that could be in another PR.
|
You're right, this test is essentially useless. Let's remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.