Skip to content

Conversation

rgrinberg
Copy link
Member

Signed-off-by: Rudi Grinberg me@rgrinberg.com

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 13967ade-4036-4fbc-91e4-aaf6644c8f4b -->

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg force-pushed the ps/rr/chore__remove_all_the_stdune__o__references branch from 054db4a to c6529c8 Compare February 23, 2025 19:20
@coveralls
Copy link

coveralls commented Feb 23, 2025

Pull Request Test Coverage Report for Build 4761

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 22.183%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/import.ml 6 8 75.0%
Totals Coverage Status
Change from base Build 4755: 0.02%
Covered Lines: 5659
Relevant Lines: 25510

💛 - Coveralls

Copy link
Collaborator

@voodoos voodoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is stdune still a dependency after this ?

edit: Since it's only the O references I guess so. Did you remove these because of upstream changes ?

@rgrinberg
Copy link
Member Author

No changes in upstream, but we'll stop publishing stdune as soon as lsp stops using it.

@rgrinberg rgrinberg merged commit 720fd2b into master May 28, 2025
6 of 7 checks passed
voodoos pushed a commit to voodoos/ocaml-lsp that referenced this pull request Jun 6, 2025
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
davesnx added a commit to davesnx/ocaml-lsp that referenced this pull request Sep 16, 2025
…rmat-mlx

* 'master' of github.com:/ocaml/ocaml-lsp:
  nix: updates (ocaml#1550)
  refactor: get rid of a bunch of [Stdune.String] uses (ocaml#1551)
  Deleted a dead link (ocaml#1549)
  Yojson 3 compat (ocaml#1534)
  Prepare release 1.23.0 (ocaml#1539)
  Delegate outline generation to Merlin (ocaml#1529)
  Fix yojson constraint (ocaml#1538)
  chore: remove all the stdune [O] references (ocaml#1483)
  Handle new kind of outline symbol (ocaml#1527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants