Add reproduction case for #1987 #2020
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
reviewed
Jan 6, 2026
Comment on lines
+19
to
+20
| - Add a test to reproduce [Locate command fails on multi-line type definitions](#1987) | ||
|
|
Collaborator
There was a problem hiding this comment.
This is not the correct section of the changelog, since 5.6.1 was released recently we should use a new "unreleased" section.
voodoos
reviewed
Jan 6, 2026
Collaborator
voodoos
left a comment
voodoos
left a comment
There was a problem hiding this comment.
Thanks ! Just a few comments.
| > let f = Fun.id | ||
| > EOF | ||
|
|
||
| $ ocamlmerlin single locate -position 3:0 -prefix List.hd -look-for interface -filename test.ml < test.ml | jq .value | jq .pos |
Collaborator
There was a problem hiding this comment.
We should always use $MERLIN instead of ocamlmerlin in tests (here and in your other PRs). It's a wrapper that perform a number of sanitization steps.
Comment on lines
+13
to
+15
| -- FIXME : locate should also points to the list interface file | ||
| $ ocamlmerlin single locate -position 2:0 -prefix List.hd -look-for interface -filename test.ml < test.ml | jq .value | ||
| "Already at definition point" |
Collaborator
There was a problem hiding this comment.
Interesting. I guess this is another example of the more generic issue: Merlin's environment before the end of the first structure item is Empty when it should be the initial env.
This is the most probable cause for that issue, you can add it to the test's comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproduces the buggy behaviour of #1987.