Add a new command to extract expression into a fresh let binding #1948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command
refactoring-extract-region
to merlin protocol which allows extracting an expression into a let binding. See the interface comments for supported casesImplementation
The implementation of the substitution is a bit hacky and relies on string manipulation, especially when the generated binding is a
and
. I couldn't deal with typedtree locations for the generated code, so I had to make a few manual location calculations that I tried to make as explicit as possible. Please tell me if there's a better way to achieve it.It still lacks a bit of testing, I'll be adding more in the next few days.
Misc
I'have also added a
fold
function inStd.Option
for the sake of conveniencecc @xvw @voodoos