Unable to install on Mac OS 10.14.6

[stevenvar]

Hi,

I'm unable to install the package on MacOS 10.14 (Mojave), while it did work when graphics was bundled with ocaml.

Here is the error:

src/unix/libgraph.h:17:10: fatal error: 'X11/Xlib.h' file not found
#include <X11/Xlib.h>

I have xquartz installed.

Doing a

sudo ln -s /opt/X11/include/X11 /usr/local/include/X11

(as mentioned here) just changes the error to:

ld: library not found for -lX11
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Any idea?

Thanks

[shenlebantongying]

Same thing will occur under macOS Catalina 10.15.1 with XQuartz installed.

Sorry, I do not quite understand OCaml's build system, but I can provide any further information to help.

[nojb]

Did you try doing

export LIBRARY_PATH=/opt/X11/lib

?

[shenlebantongying]

It works!

Thanks!

[nojb]

For info, LIBRARY_PATH is a PATH-like variable that is used to extend the list of directories where the compiler (gcc or similar) looks for static and shared variables at link-time. It is equivalent to adding those directories using an -L flag. As the location of libX11 is nonstandard on OS X the location of the library needs to be passed somehow to the compiler, which one can do using this environment variable, without need to modify the graphics build instructions.

[dra27]

That said, @nojb - presumably OCaml's configure script figured this out before (on the "just work" principle) - is it just that we're missing some logic in the conversion to Dune?

[stevenvar]

Just confirming that the

export LIBRARY_PATH=/opt/X11/lib

line works. Thanks!

[shindere]

David Allsopp (2019/12/05 01:35 -0800):

That said, @nojb - presumably OCaml's `configure` script figured this out before (on the "just work" principle) - is it just that we're missing some logic in the conversion to Dune?

It might be the case that I didn't implement looking in several directories for the graphics library, sorry about that.

[dra27]

@shindere - it's OK, the report suggests that this did work when the graphics library was in OCaml! I think AC_PATH_X was doing everything needed - the problem now for 4.09+ is that the Dune configuration system is not doing enough, and I wonder if we should fix that.

[dra27]

(I think we should fix it, because the graphics library's principal use remains in teaching, where it's very annoying to have extra steps for getting it working...)

[shindere]

David Allsopp (2019/12/05 02:07 -0800):

(I think we should fix it, because the graphics library's principal use remains in teaching, where it's very annoying to have extra steps for getting it working...)

I agree. It's just that we need to figure out who "we" is :)

[shenlebantongying]

I think the problem can be traced back to the https://github.com/ocaml/opam-repository/blob/master/packages/conf-libX11/conf-libX11.1/opam, where

[ "sh" "-exc" """PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/lib/pkgconfig:/opt/X11/lib/pkgconfig" pkg-config --libs x11""" ] {os = "macos"}
After setting the PKG_CONFIG_PATH, the pkg-config still cannot identify --libs x11.

I don't know how to modified it and recompile graphics locally :(

@ZhengchaoJiang could you look if you have a file x11.pc on your system?

If it's just a missing pkg-config path, I guess we can add it to conf-libX11 and also add a dune-configurator program in graphics to get the flags from pkg-config

[shindere]

Please, when you include textual content, as much as possible it would be better to include the textual content itself rather than a screen shot. This is useful for blind persons like me and also for search engines (there is a joke that says that the most well known blind user of the web is Google).

[shenlebantongying]

Ok, I am a noob here anyway:)

i tried to add the line below to my .zshrc

export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/lib/pkgconfig:/opt/X11/lib/pkgconfig"

then from my terminal

pkg-config --list-all | grep x11                                                                                                   
x11-xcb               X11 XCB - X Library XCB interface
x11                   X11 - X Library

the X11 can be detected.