feature(pkg): add implicit constraint on dune #8899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constraint is almost always what the user wants if they are planning to use the same dune that generated the build plan to build it Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 0d650828-dc2f-444a-b89a-993cb1fb5e90 -->
gridbugs
approved these changes
Oct 10, 2023
rgrinberg
deleted the
ps/rr/feature_pkg___add_implicit_constraint_on_dune
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constraint is almost always what the user wants if they are
planning to use the same dune that generated the build plan to build it.
There will be a need to override this, but for now it's hard coded.
Signed-off-by: Rudi Grinberg me@rgrinberg.com