[3.9] backport #8288 (sendfile buffer fix) #8306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emillon
commented
Jul 31, 2023
emillon
commented
- test: add a repro for Dune upgrades to 3.9.2 but fails to build other packages (Mint, ecryptfs) #8284 (test: add a repro for #8284 #8292)
- fix(sendfile): Flush the out_channel used in the fallback path (fix(sendfile): Flush the out_channel used in the fallback path #8288)
- test: add a repro for ocaml#8284 (ocaml#8292) - fix(sendfile): Flush the out_channel used in the fallback path (ocaml#8288) Signed-off-by: Alan Hu <alanh@ccs.neu.edu> Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.