Skip to content

feat: add a way to mark extensions as deleted #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Jul 28, 2023

Our extension mechanism is versioned, but we only support adding new versions.
However, for experimental extensions or 0.x versions we've always said that
these could be removed. This PR adds such a mechanism.

@emillon emillon requested a review from rgrinberg July 28, 2023 14:18
@emillon
Copy link
Collaborator Author

emillon commented Jul 28, 2023

See #8293 to see this in action.

@Alizter
Copy link
Collaborator

Alizter commented Jul 29, 2023

cc @ejgallego

@emillon emillon force-pushed the extension-syntax-delete branch from 626c028 to 9bfe379 Compare July 31, 2023 09:31
@emillon emillon requested a review from rgrinberg July 31, 2023 09:31
@emillon emillon force-pushed the extension-syntax-delete branch from 9bfe379 to cb1dccf Compare July 31, 2023 09:38
Our extension mechanism is versioned, but we only support adding new
versions. However, for experimental extensions or 0.x versions we've
always said that these could be removed. This PR adds such a mechanism.

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon emillon force-pushed the extension-syntax-delete branch from cb1dccf to 23beca4 Compare July 31, 2023 11:06
@emillon emillon merged commit cc60bc3 into ocaml:main Jul 31, 2023
@emillon emillon deleted the extension-syntax-delete branch July 31, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants