refactor: use Command.Args.t for Modules.pp #8109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillon
force-pushed
the
refactor-module-pp-args
branch
from
8413431 to
b482ed7
Compare
rgrinberg
requested changes
Jul 5, 2023
emillon
force-pushed
the
refactor-module-pp-args
branch
from
b482ed7 to
13e1b05
Compare
|
Good points. The changes I wanted to do (use |
This allows using the concatenation DSL instead of list and string manipulation. Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
emillon
force-pushed
the
refactor-module-pp-args
branch
from
13e1b05 to
a644738
Compare
rgrinberg
approved these changes
Jul 6, 2023
This was referenced Jul 10, 2023
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jul 10, 2023
Fixes ocaml#8158 This is an error introduced in ocaml#8109, not part of a release. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jul 10, 2023
Fixes ocaml#8158 This is an error introduced in ocaml#8109, not part of a release. Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jul 11, 2023
Fixes ocaml#8158 This is an error introduced in ocaml#8109, not part of a release. Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the concatenation DSL instead of list and string manipulation.