-
Notifications
You must be signed in to change notification settings - Fork 444
feature: async digest handling #7372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
305bfba
to
bcb1472
Compare
Then bench shows a noticeable slowdown: Compare main:
with this pr:
Also the clear build times make this clearer:
|
Thanks for the initial numbers. This PR is waiting for a change in the way we handle digests to be more multi threading friendly. |
bcb1472
to
88d0420
Compare
@Alizter and @jchavarri this is worth benchmarking now |
New bench results:
And some benches on building Dune:Main
PR
The first bench appears to be no slowdown, however the second result appears to tell me that there still is some slowdown on a clean build. This could be down to the fact that the second results use 20 jobs rather than 1. |
@Alizter digests aren't computed for null builds. |
OK that makes sense. If I get a chance I will try to test some chunkier repos to see if the slight slowdown is constant or also scales. |
88d0420
to
e5eec82
Compare
@snowleopard this option is now under config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
The PR description needs to be updated though (it claims too much?). |
Compute file digests in background threads Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: fa4d841b-d0ce-412e-b84b-d2d53c0d7eb6 -->
e5eec82
to
fc86d03
Compare
Move the computation of digests to a background thread. For now, this is guarded behind a configuration option that requires this to be enabled.
Signed-off-by: Rudi Grinberg me@rgrinberg.com