Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the lost Metrics.reset hook #4667

Merged
merged 1 commit into from
May 28, 2021
Merged

Add the lost Metrics.reset hook #4667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dune_engine/build_system.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,8 @@ let report_rule_conflict fn (rule' : Rule.t) (rule : Rule.t) =
need to delete them as they might contain garbage. *)
let pending_targets = ref Path.Build.Set.empty

let () = Hooks.End_of_build.always Metrics.reset

let () =
Hooks.End_of_build.always (fun () ->
let fns = !pending_targets in
Expand Down