Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more metrics #4649

Merged
merged 3 commits into from
May 25, 2021
Merged

Add some more metrics #4649

merged 3 commits into from
May 25, 2021

Conversation

snowleopard
Copy link
Collaborator

@snowleopard snowleopard commented May 25, 2021

This PR adds two time metrics:

  • Cycle detection (time spent in Memo.add_dep_from_caller function)
  • Generic digest computation (time spent in Digest.generic)

For the zero build of Dune, I get the following with --print-metrics:

69650/69650 computed/total nodes, 181578/181578 traversed/total edges
(2.19s total, 0.24s cycle detection, 0.06s digests, 24.7M heap words)

@snowleopard snowleopard requested review from a user and aalekseyev May 25, 2021 12:23
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
src/memo/memo.ml Show resolved Hide resolved
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
@snowleopard snowleopard merged commit c547ff3 into ocaml:main May 25, 2021
@snowleopard snowleopard deleted the add-more-metrics branch May 25, 2021 12:57
@ghost ghost mentioned this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants