Skip to content

Conversation

@Alizter
Copy link
Collaborator

@Alizter Alizter commented Jan 27, 2026

As described in

We fix the expansion of variables of unknown packages to become the empty string.

Part of the work on

@Alizter Alizter marked this pull request as ready for review January 27, 2026 12:24
@Alizter Alizter mentioned this pull request Jan 27, 2026
10 tasks
Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it is the right way to go about it, there was some prior work on capturing undefined variables and defining them. I think it was mainly to contain the undefined variable semantics from OPAM to lockfile generation, whereas undefined variables on the Dune side would always error.

Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know the package isn't in the computed lock directory, we should actually evaluate this variable when the lock directory is solved, not at build time.

@Alizter Alizter force-pushed the push-uyllyluvlwqo branch 2 times, most recently from c25ede7 to b47c4d3 Compare January 28, 2026 12:00
@Alizter Alizter marked this pull request as draft January 28, 2026 12:01
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants