feat(runtest): dune runtest for (tests) #12785
Open
+355
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
push-kryquzyywyoo
branch
2 times, most recently
from
c5de60e to
523b700
Compare
rgrinberg
reviewed
Nov 25, 2025
rgrinberg
reviewed
Nov 25, 2025
Alizter
force-pushed
the
push-kryquzyywyoo
branch
2 times, most recently
from
162a7bd to
e50dd2b
Compare
rgrinberg
reviewed
Nov 25, 2025
rgrinberg
reviewed
Nov 25, 2025
rgrinberg
reviewed
Nov 25, 2025
| >>= function | ||
| | None -> Memo.return [] | ||
| | Some source_dir -> | ||
| Source_tree.Dir.filenames source_dir |
Member
There was a problem hiding this comment.
Can't we use Dir_contents here instead? This seems like the wrong API to use.
rgrinberg
reviewed
Nov 25, 2025
|
|
||
| val make_request | ||
| : contexts:Context.t list | ||
| -> scontexts:Super_context.t Context_name.Map.t |
Member
There was a problem hiding this comment.
Seems redundant to pass both contexts and scontexts. How about just making contexts be your new super context map? Or looking up the super context by context name inside this function.
Collaborator
Author
There was a problem hiding this comment.
Yeah I wanted to avoid passing around the super context, but it looks like I will need it in the end to do dir_contents.
Alizter
force-pushed
the
push-kryquzyywyoo
branch
from
e50dd2b to
421edcd
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-kryquzyywyoo
branch
from
421edcd to
958e2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add support for running
(tests)by providing their sources todune runtest.Addresses part of #870.