Improve locations unused libs #12782
Open
+155
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
improve-locations-unused-libs
branch
5 times, most recently
from
4094914 to
ed00876
Compare
This improves the error messages for the unused libray check Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
improve-locations-unused-libs
branch
from
ed00876 to
8fe16e3
Compare
Alizter
approved these changes
Nov 24, 2025
Collaborator
Alizter
left a comment
Alizter
left a comment
There was a problem hiding this comment.
Could you add a test case for multiple unused libraries so we can see that only the first occurrence is picked in the excerpt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error messages for the unused libray check