Skip to content

Action builder alias module #12772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −6
Open

Action builder alias module #12772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca742a
dev
rgrinberg Oct 15, 2025
3fd9752
fix: Use Action_builder to build alias module
rgrinberg Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/dune_rules/module_compilation.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,12 +513,11 @@ end

let build_alias_module cctx group =
let alias_file =
let open Action_builder.O in
let+ instances =
Resolve.Memo.read_memo
@@
match Compilation_context.instances cctx with
| None -> Resolve.Memo.return []
| Some instances -> instances
| None -> Action_builder.return []
| Some instances -> Resolve.Memo.read instances
in
let project = Compilation_context.scope cctx |> Scope.project in
let modules = Compilation_context.modules cctx in
Expand All @@ -533,8 +532,7 @@ let build_alias_module cctx group =
~loc:Loc.none
sctx
~dir
(Action_builder.of_memo alias_file
|> Action_builder.write_file_dyn (Path.as_in_build_dir_exn file))
(Action_builder.write_file_dyn (Path.as_in_build_dir_exn file) alias_file)
in
let cctx = Compilation_context.for_alias_module cctx alias_module in
build_module cctx alias_module
Expand Down
Loading