feat(oxcaml): parameterised inline_tests#12707
Merged
shonfeder merged 1 commit intoocaml:mainfrom Dec 11, 2025
Merged
Conversation
Collaborator
|
Is ppx_expect building in oxcaml now? |
Collaborator
Author
|
|
art-w
force-pushed
the
parameterised-test
branch
from
008ed88 to
8a9a25f
Compare
shonfeder
reviewed
Nov 21, 2025
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Looks good! I have just a few questions and 2 small suggestions
test/blackbox-tests/test-cases/oxcaml/parameterised-inline-test.t
Outdated
Show resolved
Hide resolved
rgrinberg
reviewed
Nov 23, 2025
test/blackbox-tests/test-cases/oxcaml/parameterised-inline-test.t
Outdated
Show resolved
Hide resolved
rgrinberg
reviewed
Nov 23, 2025
art-w
force-pushed
the
parameterised-test
branch
2 times, most recently
from
f309b12 to
c0466c9
Compare
Alizter
reviewed
Dec 2, 2025
art-w
force-pushed
the
parameterised-test
branch
from
5d6125e to
e0e2764
Compare
rgrinberg
added
package management
oxcaml
art-w
force-pushed
the
parameterised-test
branch
2 times, most recently
from
1549c9c to
2d5c192
Compare
Alizter
reviewed
Dec 5, 2025
art-w
force-pushed
the
parameterised-test
branch
3 times, most recently
from
5485df8 to
98ce06a
Compare
Signed-off-by: Arthur Wendling <arthur@tarides.com>
rgrinberg
force-pushed
the
parameterised-test
branch
from
98ce06a to
912cb06
Compare
rgrinberg
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on the instantiation of parameterised libraries #12561 to support
inline_tests(marking this PR as a draft since only the last commit is new).To run the inline tests of a parameterised library, the user should specify with
(arguments ...)which implementation of the parameters to use, as otherwise the test can't be ran.Fix #12110