feat(oxcaml): add parameters field for libraries#12336
Merged
Alizter merged 1 commit intoocaml:mainfrom Oct 6, 2025
Merged
Conversation
art-w
force-pushed
the
lib-field-parameters
branch
2 times, most recently
from
3945c0e to
b7624b9
Compare
rgrinberg
requested changes
Sep 2, 2025
art-w
force-pushed
the
lib-field-parameters
branch
from
b7624b9 to
a0bc8e5
Compare
art-w
force-pushed
the
lib-field-parameters
branch
2 times, most recently
from
488cf39 to
258df6b
Compare
rgrinberg
approved these changes
Sep 14, 2025
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
LGTM. Great work on getting on preserving the lazy loading everywhere.
art-w
force-pushed
the
lib-field-parameters
branch
2 times, most recently
from
1989c1d to
8fef3ae
Compare
Alizter
reviewed
Sep 19, 2025
Alizter
reviewed
Sep 19, 2025
Collaborator
|
This looks great! I've left a few questions but they are by no means blocking. I also have another: Is it feasible for |
Alizter
approved these changes
Sep 19, 2025
Collaborator
Author
|
Thanks for the review and the fun question! I just checked, the OxCaml compiler doesn't currently support parameterizing a |
Collaborator
|
If you rebase I can merge it once the CI is done. |
Signed-off-by: ArthurW <arthur@tarides.com>
art-w
force-pushed
the
lib-field-parameters
branch
from
8fef3ae to
7f7f7dc
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
(parameters ...)field to the library stanza, to define a parameterized library (see #11963). Parameterized libraries are currently only available with the OxCaml compiler, since they require a new compiler flag-parameter Name_of_parameter(for each specified parameter) to compile the modules of the parameterized library.Fixes #12086