Skip to content

Comments

Fix 12306#12320

Merged
rgrinberg merged 3 commits intoocaml:mainfrom
hhugo:fix-12306
Aug 27, 2025
Merged

Fix 12306#12320
rgrinberg merged 3 commits intoocaml:mainfrom
hhugo:fix-12306

Conversation

@hhugo
Copy link
Collaborator

@hhugo hhugo commented Aug 27, 2025

No description provided.

hhugo added 2 commits August 27, 2025 10:38
Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>
Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>
Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes entry please.

Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>
@hhugo
Copy link
Collaborator Author

hhugo commented Aug 27, 2025

Thanks. Changes entry please.

done

@rgrinberg rgrinberg merged commit dba41be into ocaml:main Aug 27, 2025
10 of 11 checks passed
@hhugo
Copy link
Collaborator Author

hhugo commented Aug 27, 2025

this needs to be included on the 3.20 branch if you do another minor 3.20 release.

@hhugo hhugo deleted the fix-12306 branch August 27, 2025 14:00
@hhugo hhugo mentioned this pull request Aug 28, 2025
9 tasks
maiste added a commit that referenced this pull request Sep 2, 2025
Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>
Signed-off-by: Etienne Marais <self@maiste.fr>
Co-authored-by: Hugo Heuzard <hugo.heuzard@gmail.com>
maiste added a commit to maiste/opam-repository that referenced this pull request Sep 3, 2025
CHANGES:

### Fixed

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in ocaml/dune#10767. (ocaml/dune#12320, fixes ocaml/dune#12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (ocaml/dune#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (ocaml/dune#12329, fixes ocaml/dune#12321, @Alizter)

- Fix Cygwin bootstrap (ocaml/dune#12325, fixes ocaml/dune#12316, @Alizter)
rgrinberg added a commit that referenced this pull request Nov 28, 2025
Release 3.20.2

CHANGES:

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in #10767. (#12320, fixes #12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (#12329, fixes #12321, @Alizter)

- Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter)

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg added a commit that referenced this pull request Nov 28, 2025
Release 3.20.2

CHANGES:

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in #10767. (#12320, fixes #12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (#12329, fixes #12321, @Alizter)

- Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter)

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg added a commit that referenced this pull request Nov 28, 2025
Release 3.20.2

CHANGES:

- Fix jsoo separate compilation with modules_without_implementation. Regression
  introduced in #10767. (#12320, fixes #12306 @hhugo)

- Fix `runtest-js` mistakenly using wrong dependencies (#12324, @vouillon)

- Remove empty `.cram.test.t` directory during the running of a cram test.
  (#12329, fixes #12321, @Alizter)

- Fix Cygwin bootstrap (#12325, fixes #12316, @Alizter)

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants