Skip to content

Conversation

Leonidas-from-XIV
Copy link
Collaborator

PR in question is ocaml-dune/notty#10

@Leonidas-from-XIV Leonidas-from-XIV marked this pull request as draft February 14, 2025 13:00
@Leonidas-from-XIV
Copy link
Collaborator Author

Converting to draft as the commit that should be included should be the one that ends up getting merged, not from my PR but this PR should be able to show that the vendored notty builds on 5.4 thus making Dune compatible again.

PR in question is ocaml-dune/notty#10

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV marked this pull request as ready for review February 14, 2025 13:19
@Leonidas-from-XIV
Copy link
Collaborator Author

Changed the commit hash to the one of the merge commit; with that I think this PR is ready to be reviewed.

@Leonidas-from-XIV Leonidas-from-XIV merged commit 2de5398 into ocaml:main Feb 14, 2025
22 of 25 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the notty-5.4-support branch February 14, 2025 13:45
anmonteiro pushed a commit to anmonteiro/dune that referenced this pull request Apr 22, 2025
PR in question is ocaml-dune/notty#10

Signed-off-by: Marek Kubica <marek@tarides.com>
Sudha247 pushed a commit to Sudha247/dune that referenced this pull request Jul 23, 2025
PR in question is ocaml-dune/notty#10

Signed-off-by: Marek Kubica <marek@tarides.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants