Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include -opaque in dev's :standard definition #4986

Open
craff opened this issue Oct 12, 2021 · 7 comments
Open

Include -opaque in dev's :standard definition #4986

craff opened this issue Oct 12, 2021 · 7 comments

Comments

@craff
Copy link

craff commented Oct 12, 2021

The title says it all: you should not force the user to use a compiler option while you have default and ways to customize them.

@bobot
Copy link
Collaborator

bobot commented Oct 12, 2021

Could you be a little more specific? I though the -opaque is used in dev by default. So it should be in :standard.

@nojb
Copy link
Collaborator

nojb commented Oct 12, 2021

Could you be a little more specific? I though the -opaque is used in dev by default. So it should be in :standard.

In fact it isn't because -opaque is a little special as it affects the calculation of dependencies (without -opaque the .cmx are dependencies, otherwise they aren't).

@craff
Copy link
Author

craff commented Oct 12, 2021 via email

@bobot
Copy link
Collaborator

bobot commented Oct 13, 2021

@craff I don't understand what you are explaining. To rephrase @nojb, we can't let people remove -opaque in dev mode as easily as changing the flags without doing something for the computation of the dependencies.

I think the need is valid. I think a standardized opt-out would be better than meddling with the flags and dune detecting it. I just don't know at which level we should add it (dune-project, package, stanza).

@ejgallego
Copy link
Collaborator

In Coq indeed users can mess with the flags and break the Dune mode as rules won't be updated; I actually thought of at some point indeed having the coq rules analyze the flags and keep the rules in sync [or error], but that's certainly a minor optimization.

@rgrinberg
Copy link
Member

I think the need is valid. I think a standardized opt-out would be better than meddling with the flags and dune detecting it. I just don't know at which level we should add it (dune-project, package, stanza).

In the same way as we do for jsoo separate compilation.

@rgrinberg
Copy link
Member

We discussed this in meeting today. The conclusion was that if you want to control this better, feel free to submit a PR to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants