Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many branches #1654

Closed
Zimmi48 opened this issue Dec 13, 2018 · 5 comments
Closed

Too many branches #1654

Zimmi48 opened this issue Dec 13, 2018 · 5 comments

Comments

@Zimmi48
Copy link
Contributor

Zimmi48 commented Dec 13, 2018

This project has a lot of branches, and this means that it is hard to follow the development. As can be seen in https://github.com/ocaml/dune/branches/all, most of these branches are associated to merged PRs. It would be nice to at least delete these branches. Probably some old and unused branches like dev too. I would personally recommend going further by having contributors open PRs from branches on their forks (including core contributors) but this is your call. Making the number of branches smaller would already be a good improvement.

@rgrinberg
Copy link
Member

I don't have any objections to deleting old branches. I did not realize that people followed all the different branches.

@Zimmi48
Copy link
Contributor Author

Zimmi48 commented Dec 13, 2018

I did not realize that people followed all the different branches.

That's not what I meant. I mean that they might want to look at your various branches to try to infer your model of development. For instance, you have a dev branch that has not been used for a long time but can be confusing because people used to the git-flow model might wrongly think that this is the branch that PR should target.

@emillon
Copy link
Collaborator

emillon commented Dec 13, 2018

PRs should target master. I'll cleanup the merged branches so that it's less messy!

emillon added a commit to emillon/dune that referenced this issue Dec 13, 2018
Closes ocaml#1654

Signed-off-by: Etienne Millon <me@emillon.org>
@emillon
Copy link
Collaborator

emillon commented Dec 13, 2018

Done - I also clarified that bit in the contributing guide. Thanks!

@emillon
Copy link
Collaborator

emillon commented Dec 13, 2018

(And I'll also try to make my PRs from my fork :))

@Zimmi48 Zimmi48 closed this as completed Dec 13, 2018
emillon added a commit that referenced this issue Dec 13, 2018
Closes #1654

Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants