Add missing functions to pprintast (binding, longindent, payload) #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiasdrp
requested review from
NathanReb,
ceastlund,
panglesd,
patricoferris and
pitag-ha
as code owners
Collaborator
|
Thanks your contribution! Could you rebase on top of |
Signed-off-by: mattiasdrp <mattias@kojin.tech>
mattiasdrp
force-pushed
the
add-missing-pprintast-functions
branch
from
7934d8a to
4cf525e
Compare
Contributor
Author
|
Done! |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
approved these changes
Dec 10, 2024
Collaborator
NathanReb
left a comment
NathanReb
left a comment
There was a problem hiding this comment.
Thanks! I just added the changelog entry to save you the trouble. I'll merge when the CI's green again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531