Replace -dparsetree sexp output with a pretty-printed AST#530
Merged
Conversation
NathanReb
requested review from
ceastlund,
panglesd,
patricoferris and
pitag-ha
as code owners
Collaborator
Author
|
See ocaml/opam-repository#26623 for rev-deps. |
Collaborator
Author
|
I couldn't find anything in the revdeps build indicating that anyone's relying on the sexp output but you know what it's like to look through opam-ci's ppxlib revdeps builds. If you'd like to have a look @patricoferris please let me know! |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
use-pp-ast-dparsetree
branch
from
65146ca to
e9f306b
Compare
patricoferris
approved these changes
Sep 26, 2024
patricoferris
left a comment
patricoferris
left a comment
Collaborator
There was a problem hiding this comment.
Looked through the CI as best I could and looks good to me. Also did a little poking on Github search and sherlocode. I think we make the change and patch downstream breakages which I really can't imagine would be too many :)
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to replace
-dparsetreeoutput format to something more readable.I'll trigger a rev-deps build on opam to see if that would break anything.