Support 4.10 ASTs #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #23.
let-def
approved these changes
Mar 4, 2020
Contributor
let-def
left a comment
let-def
left a comment
There was a problem hiding this comment.
Looks good, some things could be simplified but this is not specific to 4.10.
Contributor
|
@aantron I don't know how this should be generated. In the previous versions, I just imported the implementation from https://github.com/ocaml-ppx/ppx_tools and qualified the paths by hand. |
Contributor
Author
|
So was |
Contributor
|
I suspect genlifter was used on ppx_tools, and I started from the output of ppx_tools. The maintainers of ppx_tools are the right people to ask, if any :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this by using it to port Bisect_ppx to 4.10 ASTs, and Bisect passes its own tests.
How should
ast_lifter_410.mlbe generated? I editedast_lifter_409.mlby hand to create it for this PR.Resolves #23.