Skip to content

Better error message when ocamlformat emit source triggering warning 50 #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

Better error message when ocamlformat emit source triggering warning 50 #2410

merged 1 commit into from
Jul 30, 2023

Conversation

@hhugo
Copy link
Collaborator

@hhugo hhugo commented Jul 21, 2023

No description provided.

@hhugo
Copy link
Collaborator Author

hhugo commented Jul 21, 2023

fix #2409

@hhugo hhugo added the no changelog set this to bypass the CI check for changelog entries label Jul 21, 2023
Julow
Julow approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy to merge once the build error is fixed.

@hhugo
Copy link
Collaborator Author

hhugo commented Jul 26, 2023

Fixed.
I've also added printing of the exception when debug is on.

@hhugo hhugo merged commit 862f3ae into main Jul 30, 2023
@hhugo hhugo deleted the invalid-comm branch July 30, 2023 18:20
KimberlWilliams
KimberlWilliams reviewed Aug 24, 2023
View reviewed changes
Copy link

@KimberlWilliams KimberlWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Julow Julow Julow approved these changes

+1 more reviewer

@KimberlWilliams KimberlWilliams KimberlWilliams left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no changelog set this to bypass the CI check for changelog entries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hhugo @Julow @KimberlWilliams