Update the preview script #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make the `-p` not optional. The default value was harmful and I was not happy with uncertain values being passed to `rm -rf`. - Take URL prefixes as `-u` and `-y` instead of user names. The constructed URL doesn't work in every setup and is better provided directly. - Push the result to the fork repository. - Arguments are quoted when needed and other style changes.
More reproducible than depending on installing it first in Opam.
These projects have similar codebase and are maintained by a small number of people.
Ppxlib has unusual code and is a good target for the tests.
Remove owl, which was not tested, sub-libraries of core, which all have similar code and index, which has similar code to irmin.
It uses an old version of OCamlformat, the diff is too big to be useful. It's also not upgradable automatically due to its Dune config.
The project hasn't been upgraded since the removal of `align-cases` and cannot be upgraded.
Julow
added
the
no changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used the preview script and made some changes.
Refactored the script itself to automate more and to remove edge cases.
Some projects are removed from the list of previews:
owlandflow: They haven't been updated in a while and the diff is now meaningless.alcotestandmirageand previewed.Changed the list of projects used in
test_branch.I added
ppxlib, which has unusual code and removed projects that have similar code source.If anyone want to add its projects to this list, this is possible.