Nudge people to the default chunk_size setting #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR nudges people to use the default
chunk_size
forparallel_for
. In all the cases I've seen the default chunk is superior in our sandmark numerical benchmarks, particularly when the number of domains gets large. This is often because tasks can turn out to be more imbalanced than people expect: a domain does GC marking, is slower due to cache effects, has a hiccup getting scheduled by the OS, etc.I have left the parallel initialization examples as is. I don't have experience to know if experiments have determined a small
chunk_size
as best for these.