Strengthen mutable_set_v5 expect test against timing differences #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal STM test
mutable_set_v5.ml
is currently run with--verbose
which includes timing (0.0s
) and subsequently diffed as an expect test. This creates the possibility of test failures due to a timing difference if it is run on a particular slow (CI) machine.I just had this happen to me on the CI of an unrelated branch which happened to take
0.1s
instead:https://github.com/ocaml-multicore/multicoretests/actions/runs/6946194440/job/18897107446
This little PR therefore removes the
--verbose
option for this expect test.