On Windows, fix stdin broken-pipe and blocking domain. Issues #793 and #792. #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
force-pushed
the
windows_read-stdin__issue_793_and_792
branch
from
bf3c248 to
69098d1
Compare
talex5
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Looks good to me - thanks!
/cc @patricoferris, who added the cstruct stubs file
* fix blocking issue on Windows : issue ocaml-multicore#793. Adding await_readable before reading fd * fix broken pipe exception : issue ocaml-multicore#792. Use Unix.read_bigarray instead of Unix_cstruct.read * replace eio_windows_cstruct_stubs.c by Unix functions. Since OCaml 5.2, Unix.read_bigarray and Unix.write_bigarray can be used.
talex5
force-pushed
the
windows_read-stdin__issue_793_and_792
branch
from
69098d1 to
d3cb04a
Compare
|
I also bumped the minimum OCaml version to 5.2, since this PR needs it. |
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jul 20, 2025
CHANGES: Bug fixes: - posix: ensure `spawn_unix` wraps errors when calling `openat` (@dijkstracula ocaml-multicore/eio#809). - Use `O_RESOLVE_BENEATH` on FreeBSD (@talex5 ocaml-multicore/eio#810, reported by @dijkstracula). FreeBSD needs `-D__BSD_VISIBLE` to be able to see this. Fixed the CI bug this revealed, which had started also affecting macos. - Ignore `ECONNRESET` on close (@talex5 ocaml-multicore/eio#787). FreeBSD returns `ECONNRESET` in certain (unclear) circumstances, but it does still close the FD successfully. If you care about this case, you should probably use `shutdown` instead and check for it there. Python and Ruby at least both explicitly check for and ignore this error too. - On Windows, fix stdin broken-pipe and blocked domains (@bdodrem @talex5 ocaml-multicore/eio#795). - Ensure blocking FDs are ready before trying to use them. - Replace `eio_windows_cstruct_stubs.c` by Unix functions added in OCaml 5.2, which correctly handle Window's strange use of `EPIPE`. Documentation: - Documentation fixes (@jonludlam ocaml-multicore/eio#813). - Minor documentation improvements (@talex5 ocaml-multicore/eio#794). Build fixes: - Disable `dune subst` (@talex5 ocaml-multicore/eio#789).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jul 20, 2025
CHANGES: Bug fixes: - posix: ensure `spawn_unix` wraps errors when calling `openat` (@dijkstracula ocaml-multicore/eio#809). - Use `O_RESOLVE_BENEATH` on FreeBSD (@talex5 ocaml-multicore/eio#810, reported by @dijkstracula). FreeBSD needs `-D__BSD_VISIBLE` to be able to see this. Fixed the CI bug this revealed, which had started also affecting macos. - Ignore `ECONNRESET` on close (@talex5 ocaml-multicore/eio#787). FreeBSD returns `ECONNRESET` in certain (unclear) circumstances, but it does still close the FD successfully. If you care about this case, you should probably use `shutdown` instead and check for it there. Python and Ruby at least both explicitly check for and ignore this error too. - On Windows, fix stdin broken-pipe and blocked domains (@bdodrem @talex5 ocaml-multicore/eio#795). - Ensure blocking FDs are ready before trying to use them. - Replace `eio_windows_cstruct_stubs.c` by Unix functions added in OCaml 5.2, which correctly handle Window's strange use of `EPIPE`. Documentation: - Documentation fixes (@jonludlam ocaml-multicore/eio#813). - Minor documentation improvements (@talex5 ocaml-multicore/eio#794). Build fixes: - Disable `dune subst` (@talex5 ocaml-multicore/eio#789).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The purpose of this pull request is to
fix blocking stdin on Windows : issue on Windows, reading from stdin blocks the whole domain. #793.
Adding
await_readablebefore reading fdfix broken pipe exception : issue on Windows reading stdin from a pipe command throws"broken pipe" exception #792.
Use
Unix.read_bigarrayinstead ofUnix_cstruct.readreplace eio_windows_cstruct_stubs.c by Unix functions.
Since Ocaml 5.2,
Unix.read_bigarrayandUnix.write_bigarrayare available.